Improve proptypes oneof warnings - Fixes #1919 #6940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipshurpik
changed the title
ghost
added
|
Could you provide a test case? |
| for (var i = 0; i < expectedValues.length; i++) { | ||
| if (is(propValue, expectedValues[i])) { | ||
| return null; | ||
| } | ||
| if (getPropType(expectedValues[i]) === 'function' && expectedValues[i].name === 'bound checkType') { |
There was a problem hiding this comment.
Could you set a flag on the bound checkType instead? This way if we change its name, this won’t start creating false positives.
|
Thanks for the PR! Let’s avoid using |
|
thanks, will work on improvements :) |
|
Closing in favor of #7526 but thanks for taking the time! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1919
As I see there is two problems:
Welcome to your suggestions
reactEurope-hackathon